from Hacker News

Send small PRs (Google eng-practices)

by amir-h on 10/25/21, 12:58 PM with 5 comments

• by tharkun__ on 10/26/21, 1:19 AM

  I really like this. We try for small PRs as well. Has all of the benefits listed!

  What they aren't good at is to show the overall intent of the whole change. I.e. what I've found is that sometimes an individual PR is easy to review and approve because it seems innocuous and totally fine. But in the overall grand scheme of things I'd have "questions". I might even question the overall concept of the whole thing but I don't have the full picture and what seems innocent as a small PR is actually going towards a grand vision I can't support.

  I won't deny that I've used the same technique to get otherwise probably more controversially discussed stuff through ;)

• by say_it_as_it_is on 10/26/21, 9:32 AM

  Google ought to spend effort on understanding and then explaining how to chunk large pieces of work that don't seem to qualify. Recommending that an engineer asks their peers for help shows that management also has no idea how to chunk the work.

• by the_arun on 10/25/21, 7:42 PM

  What is a CL?