by navalsaini on 7/21/18, 6:09 AM with 8 comments
Is it common for one or two people on a team to receive a lot of styling comments? I am pretty sure this is a good mix of product focussed and pure software engineering focussed groups.
Drop a paragraph on what story or insight comes to your mind on the subject.
by fardo on 7/21/18, 9:29 AM
>Your style isn’t up to spec
If you always smell crap, check the bottom of your shoes. I’ve found team style guides to be useless generally, but attempting to emulate team style by looking at existing code is a winning move. Coding is a team effort, and even if it’s a little extra work, a little beautification can go a long way towards readability.
>Code reviewers want or are incentivized to help
Many code reviewers make a point not to leave a nontrivial review without commenting. Whether this is because they want to help, or because in many workplaces, the code review metric optimized for is “comments closed”, some people will feel obligated. When there’s no substance to dissect, style is often substituted
>Someone’s giving you a hard time for irrational reasons
This is an interpersonal issue. You don’t, in my opinion, need to worry how others will view you if this happens since most people can tell when somebody is just being a dick in a CR. If you’re concerned about this, try to figure out why you two have beef by asking them and either resolve it, ignore/forgive it and move on (some hills aren’t worth dying on), involve management or HR, or change roles
by sloaken on 7/21/18, 11:08 AM
I assume PR is not public relations?
<story> Long time ago I worked at this place where the CEO was known for needed to fel involved without actually being involved. My boss had me work on a demo that the CEO would use for potenial clients. In the middle of the demo it did some odd steps. Clearly a mistake, I had just failed to remove a part in the scripting. Well I showed this to my boss, with the odd part in, since I did not realize it was there. When it happened I commented that I obviously need to remove that part. He told me to leave it in, as it would give the CEO something to complain about, and feel like he had made a real contribution. When shown to the CEO he loved the presentation except for that one glitch. You could almost read his mind ("oh my what would these foolish developers do without me"). <story off>
Sadly I have seen this repeated many times.
by spicyj on 7/21/18, 4:40 PM