from Hacker News

Git-appraise: Distributed code review system for Git repos

by ktt on 12/13/15, 11:48 AM with 26 comments

• by jonahx on 12/14/15, 7:02 PM

  Upvoted because this looks cool and I'm definitely your target audience. The README doesn't give me a great sense of how this actually works, though. A 5 minute video, or even a hypothetical example with some screenshots intermixed, would help a lot.

• by flyinprogramer on 12/14/15, 10:25 PM

  This seems like an awesome tool. Sadly my comment has more to do with Go, as I'm new to the language and trying to learn.

  When building a tool that uses git I'm wondering if it is better practice to use git2go (https://github.com/libgit2/git2go) or to do what this author did which is wrap the git command line tool: https://github.com/google/git-appraise/blob/master/repositor...

• by nine_k on 12/14/15, 5:43 PM

  I always thought that built-in comments and docs are an excellent feature of Fossil [1], and wished git had it.

  Kudos to the author.

  [1]: http://www.fossil-scm.org

• by ktt on 12/14/15, 9:19 PM

  What's interesting is that this project seems to be using itself for code review.

  Clone the repo and then fetch notes manually:

      git fetch origin refs/notes/*:refs/notes/*
  

  After installing it through "go get" check existing code reviews with "git appraise list".

  There are notes from Jenkins and comments from developers as far as I can see.

  Seems to be a little bit slow on my computer but the idea is really brilliant.

• by secure on 12/14/15, 6:59 PM

  I can’t find any mention of GUI frontends for git-appraise.

  While I prefer to write code in my terminal, I like to switch settings for reviewing code — with GitHub’s Pull Requests, I can just do it in the browser. Can I use git-appraise in my browser? Is there a stand-alone tool?

• by pm90 on 12/14/15, 5:22 PM

  How does this compare w.r.t Gerrit?

  I see that an advantage is that it doesn't require server-side setup. But wouldn't one require some sort of central repo to coordinate code reviews and CI tests?

• by tremguy on 12/14/15, 4:08 PM

  Seems solid, are there any editors for this?

• by thesorrow on 12/14/15, 5:01 PM

  Nice ! I guess storing issues and comments is possible too ?

• by soinus on 12/15/15, 9:52 AM

  Damn, feeling completely dumb. I have installed the tool, and am trying it on one of my projects. After I do some local commits `git-appraise request` returns `There are no commits included in the review request`. Is there any tutorial or more documentation available somewhere? Or do I need to dig into its code to find the issue?

• by m4dc4pXXX on 12/16/15, 11:37 PM

  Trying to use this and I get "exit status 128" for all reasonable invocations of "git appraise request ...".

  Looks seriously cool and I am sad!

• by ubercow on 12/14/15, 9:31 PM

  How does this handle identity? For example, what's preventing me from just changing my name and reviewing myself?